Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21003
to look at the new patch set (#3).
Change subject: IMPALA-12788: Fix HBaseTable still get loaded even if HBase is
down
......................................................................
IMPALA-12788: Fix HBaseTable still get loaded even if HBase is down
When loading a table backed by HBase, it's intended to check whether the
table exists in HBase in HBaseTable.load() and loadFromThrift().
However, the current check just gets the table object and then closes
it. This won't fail even if HBase is down. See JIRA description for the
stacktrace.
This patch fixes the check to fetch the column family names which is a
light-weight request and will fail if HBase is down or the table doesn't
exist in HBase.
Splits the following tests to skip the HBase part when running on S3:
- TestNestedStructsInSelectList.test_struct_in_select_list
- TestDdlStatements.test_alter_set_column_stats
- TestShowCreateTable.test_show_create_table
Tests:
- Run CORE tests on S3
Change-Id: Ib497f11ecc338d0f84d3d7bd8ccfcf8da4def0cb
---
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
A
testdata/workloads/functional-query/queries/QueryTest/alter-hbase-table-set-column-stats.test
M
testdata/workloads/functional-query/queries/QueryTest/alter-table-set-column-stats.test
A
testdata/workloads/functional-query/queries/QueryTest/show-create-table-hbase.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
A
testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list-hbase.test
M
testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list.test
M tests/metadata/test_ddl.py
M tests/metadata/test_show_create_table.py
M tests/query_test/test_nested_types.py
10 files changed, 113 insertions(+), 95 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/21003/3
--
To view, visit http://gerrit.cloudera.org:8080/21003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib497f11ecc338d0f84d3d7bd8ccfcf8da4def0cb
Gerrit-Change-Number: 21003
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
