Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 )
Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21019/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21019/1//COMMIT_MSG@8 PS1, Line 8: trivial changes in StorageDescriptor > Fair thought!! I don't have an answer for this. ack, if storedAsSubDirectories can change between unert and false frequently, then this seems useful http://gerrit.cloudera.org:8080/#/c/21019/1//COMMIT_MSG@15 PS1, Line 15: skipped for all other changes in S > Agree with you. It is very unlikely that a new field added in SD would requ yeah, it seems very unlikely that a new field will need file metadata reload, but it also unlikely that it will be changed frequently. I would opt for safety here and allow difference only in selected members, if it's not very hard to implement it. http://gerrit.cloudera.org:8080/#/c/21019/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21019/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2705 PS1, Line 2705: tbl.setLastSyncedEventId(currentHmsEventId); wasn't this a bug before this change? what happened if isSkipFileMetadataReload was true syncToLatestEventId was also true? In this case we shouldn't skip till the current HMS event, as this may skip file modifying events -- To view, visit http://gerrit.cloudera.org:8080/21019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fd9a9504bf93d2529dc7accbf436ad83e51d8ac Gerrit-Change-Number: 21019 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Feb 2024 16:23:06 +0000 Gerrit-HasComments: Yes
