Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21037 )

Change subject: IMPALA-12811: Exception during re-analyze can be lost
......................................................................


Patch Set 2:

(1 comment)

Thanks for the comment!

http://gerrit.cloudera.org:8080/#/c/21037/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java:

http://gerrit.cloudera.org:8080/#/c/21037/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@649
PS1, Line 649:       logRewriteErrorNoThrow(analysisResult_.stmt_, e);
> Could it be useful to print the original error message within an additional
I had a version like that, but I always got an exception and the code was a bit 
ugly. But still, there's a possibility that it might output useful information, 
so I moved the try-catch into a separate method and invoke that.



--
To view, visit http://gerrit.cloudera.org:8080/21037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6e36b08703c07a2a8d68a4ec0e8ddd65ba03199
Gerrit-Change-Number: 21037
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 18:00:29 +0000
Gerrit-HasComments: Yes

Reply via email to