Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 )
Change subject: IMPALA-12824: Adds built-in functions prettyprint_duration and prettyprint_bytes. ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/21038/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21038/8//COMMIT_MSG@7 PS8, Line 7: IMPALA-12824: Adds built-in functions prettyprint_duration and prettyprint_bytes. > nit: keep title from patch set 7? I like the slight longer title just because it is a bit more descriptive on the purpose of this change. http://gerrit.cloudera.org:8080/#/c/21038/8/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: http://gerrit.cloudera.org:8080/#/c/21038/8/be/src/exprs/string-functions.h@239 PS8, Line 239: /// Converts microseconds stored as an integer value into human readable time durations. > nanoseconds? Done http://gerrit.cloudera.org:8080/#/c/21038/8/be/src/exprs/string-functions.h@240 PS8, Line 240: microseconds > nanoseconds? if is is nanoseconds then example result also needs changing. Done http://gerrit.cloudera.org:8080/#/c/21038/8/tests/query_test/test_prettyprint_duration.py File tests/query_test/test_prettyprint_duration.py: http://gerrit.cloudera.org:8080/#/c/21038/8/tests/query_test/test_prettyprint_duration.py@23 PS8, Line 23: class TestPrettyPrintDuration(ImpalaTestSuite): > I don't know maybe this could have been combined with TestPrettyPrintBytes I like keeping them separate since I can see expanding prettyprint_duration to take a second parameter for the input duration's units. Instead of always pretty printing nanoseconds, the function could pretty print microseconds, milliseconds, seconds, etc. -- To view, visit http://gerrit.cloudera.org:8080/21038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 23:17:50 +0000 Gerrit-HasComments: Yes
