Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20986 )
Change subject: IMPALA-12782: Show info of the event processing in /events webUI ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/20986/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20986/3/be/src/catalog/catalog-server.cc@964 PS3, Line 964: if (progress_info.num_filtered_events > 0) { > There is a possibility of progress_info.num_filtered_events being 0. Nice catch! http://gerrit.cloudera.org:8080/#/c/20986/2/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/20986/2/common/thrift/JniCatalog.thrift@1066 PS2, Line 1066: } > Nice catch! I planned to show the MetastoreEvent at the beginning but decid In patch set 3, I finally replace this field with 'current_event_batch_size' and show it in the page. http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@678 PS3, Line 678: LOG.info("Ignored exception", e); > nit: What is your opinion about just logging at this InterruptedException i Removed this. http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1137 PS3, Line 1137: progressInfo.current_event_batch_size = currentFilteredEvent_ != null ? > There is a possibility of currentFilteredEvent_ being null. Recommend a che Nice catch! http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1192 PS3, Line 1192: lastSyncedEventTimeSecs_.set(e.getEventTime()); > Recommend resetProgress() here as well. Nice catch! http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1194 PS3, Line 1194: return; > nit: Need not set currentEventIndex_ explicitly to 0 now. Done -- To view, visit http://gerrit.cloudera.org:8080/20986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e7d4952c7fd04ae89b6751204499bf9dd99f57c Gerrit-Change-Number: 20986 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Feb 2024 08:41:14 +0000 Gerrit-HasComments: Yes
