Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21026 )
Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables ...................................................................... Patch Set 7: (7 comments) Thanks for working on this change! http://gerrit.cloudera.org:8080/#/c/21026/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21026/7//COMMIT_MSG@13 PS7, Line 13: requires fully qualified Why do we need this restriction? SELECT from metadata files requires this restriction to avoid ambiguity. But here it's clear that we are expecting a table, so I think it would make sense to make it more convenient. http://gerrit.cloudera.org:8080/#/c/21026/7//COMMIT_MSG@30 PS7, Line 30: metadata tables Another reason could be different authz policies for different metadata tables. http://gerrit.cloudera.org:8080/#/c/21026/7/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21026/7/be/src/service/client-request-state.cc@361 PS7, Line 361: case TCatalogOpType::SHOW_VIEWS: { We could also have a TCatalogOpType::SHOW_METADATA_TABLES http://gerrit.cloudera.org:8080/#/c/21026/7/be/src/service/frontend.h File be/src/service/frontend.h: http://gerrit.cloudera.org:8080/#/c/21026/7/be/src/service/frontend.h@66 PS7, Line 66: in typo: is http://gerrit.cloudera.org:8080/#/c/21026/7/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21026/7/fe/src/main/cup/sql-parser.cup@2934 PS7, Line 2934: ShowTablesStmt Did you think about creating a ShowMetadataTablesStmt? That might make the code a bit more clean at some places. http://gerrit.cloudera.org:8080/#/c/21026/7/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: http://gerrit.cloudera.org:8080/#/c/21026/7/fe/src/main/java/org/apache/impala/service/MetadataOp.java@368 PS7, Line 368: nit: too much indent http://gerrit.cloudera.org:8080/#/c/21026/7/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/21026/7/tests/authorization/test_authorization.py@146 PS7, Line 146: % nit: for consistency, I think it's better not to mix % and format() in one method -- To view, visit http://gerrit.cloudera.org:8080/21026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide10ccf10fc0abf5c270119ba7092c67e712ec49 Gerrit-Change-Number: 21026 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2024 15:55:55 +0000 Gerrit-HasComments: Yes
