Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21077 )
Change subject: IMPALA-12847: Expose computeScanRangeLocations and computeStats ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@218 PS2, Line 218: if > nit: 'if' instead of 'is' Done http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@221 PS2, Line 221: protect > Can we make this protected to be consistent with partitions_ member veriab Done http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@431 PS2, Line 431: getSampledOrRawParti > It would be preferable to name this method such that it reflects it can ret Done http://gerrit.cloudera.org:8080/#/c/21077/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1161 PS2, Line 1161: If 'sampledPartitions_' is not > Since this method is no longer checking sampledParams_ itself but relying o Done -- To view, visit http://gerrit.cloudera.org:8080/21077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia621309c67455bb599f71bec9efc1f67fc085022 Gerrit-Change-Number: 21077 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Feb 2024 02:21:15 +0000 Gerrit-HasComments: Yes
