Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21063 )
Change subject: IMPALA-12834: Add number of concurrent queries to profile ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21063/3/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21063/3/be/src/scheduling/admission-controller.cc@189 PS3, Line 189: Number of current running queries in designated executor group I think this description is somewhat misleading, its actual meaning seems to align more with "Number of running queries in designated executor group when this query admitted". Alternatively, if we could calculate the average query load during the execution of the query, I think it would be more useful than a single value at the time of query admitted. -- To view, visit http://gerrit.cloudera.org:8080/21063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8389215b60022b39e7d171d6fc2418acca7c0658 Gerrit-Change-Number: 21063 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Thu, 29 Feb 2024 03:46:48 +0000 Gerrit-HasComments: Yes
