Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21096 )
Change subject: IMPALA-12855: Fix NPE in firing RELOAD events when the partition doesn't exist ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21096/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21096/1//COMMIT_MSG@26 PS1, Line 26: idention typo http://gerrit.cloudera.org:8080/#/c/21096/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21096/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6799 PS1, Line 6799: List<Long> eventId Not related to the current bug, but using the events ids generated here looks strange to me. At this point we are after reloading the table - what will happen to events that arrived during the reload? Wouldn't it be better to get the last event id from HMS before reloading the table and use that one to skip events? + this mechanism would also work if enable_reload_events=false For self event detection using these event ids is correct but they are also used to skip all events with lower event id: https://github.com/apache/impala/blob/30fbcc94ea08bb0a5eb58d68bcce9c2a0eb9750e/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java#L1219 -- To view, visit http://gerrit.cloudera.org:8080/21096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01af3624bf7cf5cd69935cffa28d54f6a6807504 Gerrit-Change-Number: 21096 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Mar 2024 15:05:49 +0000 Gerrit-HasComments: Yes
