Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21091 )
Change subject: IMPALA-12863: Fix toolchain container builds for CentOS 7, SLES 12 & 15 ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21091/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21091/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12863: Fix toolchain container builds for CentOS 7, SLES 12 & 15 > Yeah, makes sense. Done http://gerrit.cloudera.org:8080/#/c/21091/2//COMMIT_MSG@19 PS2, Line 19: build requires the 'hostname' utility from it. > Sentence fragment? Maybe libncurses-devel is supposed to come before "can b Done, rephrased; added more details. http://gerrit.cloudera.org:8080/#/c/21091/2/docker/sles12.df File docker/sles12.df: http://gerrit.cloudera.org:8080/#/c/21091/2/docker/sles12.df@12 PS2, Line 12: > Ack Done -- To view, visit http://gerrit.cloudera.org:8080/21091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e730abb6667bf00735ea62c35377591b68452ce Gerrit-Change-Number: 21091 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Sat, 02 Mar 2024 18:00:09 +0000 Gerrit-HasComments: Yes