Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 )
Change subject: [DOCS] Add Impala docs from branch 2.x ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10258/2/docs/build/html/shared/ImpalaVariables.html File docs/build/html/shared/ImpalaVariables.html: http://gerrit.cloudera.org:8080/#/c/10258/2/docs/build/html/shared/ImpalaVariables.html@1 PS2, Line 1: <!DOCTYPE html According to https://gerrit.cloudera.org/#/c/6604/1/docs/build/html/shared/ImpalaVariables.html@33 ImpalaVariables.html is not needed for the site. https://cwiki.apache.org/confluence/display/IMPALA/Pushing+Impala+docs+to+impala.apache.org mentions not including it as well. I get that there are manual steps here and some additional tooling would help in the future. http://gerrit.cloudera.org:8080/#/c/10258/2/docs/build/html/shared/impala_common.html File docs/build/html/shared/impala_common.html: http://gerrit.cloudera.org:8080/#/c/10258/2/docs/build/html/shared/impala_common.html@1 PS2, Line 1: <!DOCTYPE html https://gerrit.cloudera.org/#/c/6604/1/docs/build/html/shared/impala_common.html and https://cwiki.apache.org/confluence/display/IMPALA/Pushing+Impala+docs+to+impala.apache.org indicate this file isn't needed either. http://gerrit.cloudera.org:8080/#/c/10258/2/docs/build/impala.pdf File docs/build/impala.pdf: http://gerrit.cloudera.org:8080/#/c/10258/2/docs/build/impala.pdf@1 PS2, Line 1: %PDF-1.4 This has sneaked in again. http://gerrit.cloudera.org:8080/#/c/10258/2/impala-docs.html File impala-docs.html: http://gerrit.cloudera.org:8080/#/c/10258/2/impala-docs.html@132 PS2, Line 132: 2.11 > 2.12* Nice catch. -- To view, visit http://gerrit.cloudera.org:8080/10258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I4e94fb12984974e280d3c6aeab384c1021b7f76a Gerrit-Change-Number: 10258 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Ambreen Kazi <ambreen.k...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 01 May 2018 19:38:01 +0000 Gerrit-HasComments: Yes
