Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 )
Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax ...................................................................... Patch Set 1: (2 comments) This is a welcome addition, I had some ideas about structuring it differently. http://gerrit.cloudera.org:8080/#/c/21083/1/docs/topics/impala_alter_table.xml File docs/topics/impala_alter_table.xml: http://gerrit.cloudera.org:8080/#/c/21083/1/docs/topics/impala_alter_table.xml@515 PS1, Line 515: <b>To change the column or order the records are sorted by:</b> I found this feature a bit confusing. I tried to come up with a simple summary, the best I could come up with quickly was "To specify a sort order for new records that are added to the table" http://gerrit.cloudera.org:8080/#/c/21083/1/docs/topics/impala_alter_table.xml@521 PS1, Line 521: Specifying the sort order is optional. The default sort order is <codeph>LEXICAL</codeph>. This seems useful. I wonder if this should be merged into the doc in https://impala.apache.org/docs/build/html/topics/impala_create_table.html as that has a lot of good detail. Then maybe we can somehow have a summary here and link to create table for the details. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/21083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb348d8395a6140f0be200d73e2f22fded9a5116 Gerrit-Change-Number: 21083 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Mar 2024 02:28:48 +0000 Gerrit-HasComments: Yes
