Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21065 )
Change subject: [WIP]IMPALA-12832: Implicit invalidate metadata on event failures ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/21065/16/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21065/16/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@677 PS16, Line 677: >= nit: It seems counterintuitive to use ">=" for the ratio. I think using "<=" is better. E.g. a ratio of 100% raising exceptions means "Math.random() <= 100%". http://gerrit.cloudera.org:8080/#/c/21065/16/tests/metadata/test_event_processing_error.py File tests/metadata/test_event_processing_error.py: http://gerrit.cloudera.org:8080/#/c/21065/16/tests/metadata/test_event_processing_error.py@28 PS16, Line 28: CATALOGD_ARGS = "--catalog_topic_mode=minimal "\ : "--process_event_failure=true "\ : "--inject_process_event_failure_event_types="\ : "'ALTER_TABLE,ADD_PARTITION,"\ : "ALTER_PARTITION,INSERT,ABORT_TXN,COMMIT_TXN'" nit: This is now only used once. Can we put it to be above test_event_processor_error_stress_test() directly? On the other hand, can we set the failure ratio as 50%? So the stress test covers both positive and negative cases. -- To view, visit http://gerrit.cloudera.org:8080/21065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia67fc04c995802d3b6b56f79564bf0954b012c6c Gerrit-Change-Number: 21065 Gerrit-PatchSet: 16 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 05:14:13 +0000 Gerrit-HasComments: Yes
