Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21111 )
Change subject: IMPALA-12689: Change TPC-H and TPC-DS builds to respect CFLAGS ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21111/1/source/tpc-ds/build.sh File source/tpc-ds/build.sh: http://gerrit.cloudera.org:8080/#/c/21111/1/source/tpc-ds/build.sh@38 PS1, Line 38: sed -i -r "s/^(LINUX_CFLAGS\s*=.*)/\1 ${CFLAGS}/" makefile Could this be applied repeatedly on repeated builds? I don't think it would cause issues, just messy. http://gerrit.cloudera.org:8080/#/c/21111/1/source/tpc-h/build.sh File source/tpc-h/build.sh: http://gerrit.cloudera.org:8080/#/c/21111/1/source/tpc-h/build.sh@50 PS1, Line 50: # The build makefile doesn't respect the CFLAGS environment variable directly, Why does line wrapping differ between this and the other file? -- To view, visit http://gerrit.cloudera.org:8080/21111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f999b71c56a72c14f1beeea99a3689b82a4d45a Gerrit-Change-Number: 21111 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Mar 2024 17:18:24 +0000 Gerrit-HasComments: Yes
