Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21114 )
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java File java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java: http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@437 PS1, Line 437: boolean generatedCodeOutOfDate = false; > Do we need to worry about externalTables? Good point, that is something I'm missing. We want to look at any .dat files and make sure they are not out of date. They are generated at the same time as the other files, but for completeness it is still a good idea. -- To view, visit http://gerrit.cloudera.org:8080/21114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643 Gerrit-Change-Number: 21114 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Mar 2024 17:36:45 +0000 Gerrit-HasComments: Yes
