Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21112 )
Change subject: IMPALA-12730: Don't use -Weverything for clang-tidy ...................................................................... IMPALA-12730: Don't use -Weverything for clang-tidy For current clang-tidy builds, we enable -Weverything and then explicitly disable a couple verbose warnings. Clang-tidy uses these warnings to produce its clang-diagnostic-* issues. This gives clang-tidy the maximum flexibility to enforce any warning the Clang can produce, but in practice, we disable them via the .clang-tidy file's Checks: section. The output from a -Weverything build is enormous and hard to navigate. When there is a compilation issue, digging through the logs is arduous. Clang discourages the use of -Weverything, as it contains many noisy warnings. This changes the clang-tidy build to use -Wextra instead and shrinks the list of disabled clang-diagnostic-* issues accordingly. Testing: - Verified that bin/run_clang_tidy.sh passes Change-Id: Ib4f4cc9a6d040b90495496b2396a26f3c5189231 Reviewed-on: http://gerrit.cloudera.org:8080/21112 Reviewed-by: Michael Smith <michael.sm...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M .clang-tidy M be/CMakeLists.txt 2 files changed, 9 insertions(+), 48 deletions(-) Approvals: Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib4f4cc9a6d040b90495496b2396a26f3c5189231 Gerrit-Change-Number: 21112 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
