Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20986 )
Change subject: IMPALA-12782: Show info of the event processing in /events webUI ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20986/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1192 PS3, Line 1192: * @throws MetastoreNotificationException > Sorry i didn't realise that resetProgress() was called in finally. It is no I remove calling it in finally since it will reset currentEvent_ for exceptions which causes no event details shown in the error message. So we still need this here. http://gerrit.cloudera.org:8080/#/c/20986/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20986/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1234 PS6, Line 1234: String desc = String.format("Processing %s on %s, eventId=%d", > Nit: we could probably remove L#1195 and L#1226 and add that here. It's intended to not resetting the progress info when hitting exceptions. So currentEvent_ won't be null and can be used in the error message at L1001. http://gerrit.cloudera.org:8080/#/c/20986/6/www/events.tmpl File www/events.tmpl: http://gerrit.cloudera.org:8080/#/c/20986/6/www/events.tmpl@24 PS6, Line 24: <pre>{{event_processor_error_msg}}</pre> > nit: will we have event-id and decompressed event message in the event mess Yes but with compressed event message. There is an example in IMPALA-12053. This is an existing feature added by IMPALA-12053. Just move it to the top to highlight the error. http://gerrit.cloudera.org:8080/#/c/20986/6/www/events.tmpl@43 PS6, Line 43: <td>Latest Event in Metastore</td> > nit: should we say "Latest Event in Metastore"? Done -- To view, visit http://gerrit.cloudera.org:8080/20986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e7d4952c7fd04ae89b6751204499bf9dd99f57c Gerrit-Change-Number: 20986 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Mar 2024 11:39:32 +0000 Gerrit-HasComments: Yes
