Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20886 )
Change subject: IMPALA-12626: Capture tables in query for log ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/20886/7/be/src/service/query-state.cc File be/src/service/query-state.cc: http://gerrit.cloudera.org:8080/#/c/20886/7/be/src/service/query-state.cc@182 PS7, Line 182: > Oops, I was thinking of a different problem. But the list of tables is alre On second thought, there is no sense in sorting the list of tables since the end users will sort (or not sort) according to their needs. http://gerrit.cloudera.org:8080/#/c/20886/14/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/20886/14/tests/util/workload_management.py@603 PS14, Line 603: assert data[index] != "" Please update this assert to check that the data in the query table is accurate. -- To view, visit http://gerrit.cloudera.org:8080/20886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c9c80b2adf7f3e44225a191fe8eb9df3c4bc5aa Gerrit-Change-Number: 20886 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Mar 2024 17:58:10 +0000 Gerrit-HasComments: Yes
