Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 )
Change subject: IMPALA-12872: Use Calcite for ... ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21109/5/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/21109/5/fe/pom.xml@616 PS5, Line 616: <dependency> : <groupId>org.apache.calcite</groupId> : <artifactId>calcite-core</artifactId> : <version>1.36.0</version> : </dependency> : <dependency> : <groupId>org.apache.calcite.avatica</groupId> : <artifactId>avatica-core</artifactId> : <version>1.23.0</version> : </dependency> I think fe doesn't actually need these dependencies, and they could be declared in experimental-planner's pom.xml. Separately, the versions should be the variables declared in java/pom.xml (e.g. ${calcite.version} or ${calcite.avatica.version} ). Make sure the values in bin/impala-config.sh match what you want (right now bin/impala-config.sh's version for Calcite is older). -- To view, visit http://gerrit.cloudera.org:8080/21109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I453fd75b7b705f4d7de1ed73c3e24cafad0b8c98 Gerrit-Change-Number: 21109 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Mar 2024 23:52:03 +0000 Gerrit-HasComments: Yes
