Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21148 )
Change subject: IMPALA-12903: Querying virtual column FILE__POSITION for TEXT and JSON tables crashes Impala ...................................................................... Patch Set 1: (4 comments) Thanks for the fix. http://gerrit.cloudera.org:8080/#/c/21148/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21148/1//COMMIT_MSG@19 PS1, Line 19: let Nit: lets. http://gerrit.cloudera.org:8080/#/c/21148/1/testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-generic.test File testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-generic.test: http://gerrit.cloudera.org:8080/#/c/21148/1/testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-generic.test@158 PS1, Line 158: ---- QUERY Are these the queries where some files in the table do not support FILE_POSITION but after pruning the remaining ones do? You could describe the situation in a comment (and possibly include "Regression test for IMPALA-12903"). http://gerrit.cloudera.org:8080/#/c/21148/1/testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-negative.test File testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-negative.test: http://gerrit.cloudera.org:8080/#/c/21148/1/testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-negative.test@1 PS1, Line 1: ==== Is FILE_POSITION the only virtual column that could cause this bug before this change? If there are others, we could have them instead of FILE_POSITION in some of these queries (and possibly also in virtual-column-file-position-generic.test). http://gerrit.cloudera.org:8080/#/c/21148/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/21148/1/tests/query_test/test_scanners.py@183 PS1, Line 183: parquet Is it possible to set this to JSON or TEXT? It doesn't affect anything but when reading the code 'parquet' could be confusing. -- To view, visit http://gerrit.cloudera.org:8080/21148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e1af8d526f9046aceddb5944da9e6f9c63768b0 Gerrit-Change-Number: 21148 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Mar 2024 16:45:47 +0000 Gerrit-HasComments: Yes
