Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21088 )
Change subject: IMPALA-12802: Support ALTER TABLE for JDBC tables ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java: http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteExpireSnapshotsStmt.java@49 PS3, Line 49: Nit: extra space at the beginning http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java: http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java@39 PS3, Line 39: @Override : public String getOperation() { return "SET"; } I think this class isn't used directly, so another option is for this to be an abstract class that doesn't specify this and require subclasses to implement it. http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@228 PS3, Line 228: unset properties of DataSource. Nit: Maybe this should be "Cannot change internal properties of DataSource" http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/21088/3/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@148 PS3, Line 148: unset properties of DataSource. Nit: maybe say "internal properties" to emphasize that these are set by us. -- To view, visit http://gerrit.cloudera.org:8080/21088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ebb5de2c686d2015db78641f78299dd5f33621e Gerrit-Change-Number: 21088 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Mar 2024 23:27:36 +0000 Gerrit-HasComments: Yes
