Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 )
Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10265/1/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/10265/1/be/src/rpc/thrift-util.cc@209 PS1, Line 209: strncmp(PACKAGE_VERSION, "0.9.0", 5) = > Oh missed that earlier comment. We had some static_assert() from line 63-68 Done http://gerrit.cloudera.org:8080/#/c/10265/1/be/src/rpc/thrift-util.cc@209 PS1, Line 209: strncmp(PACKAGE_VERSION, "0.9.0", 5) = > How did the test pass to begin with ? Also, not sure if it warrants a strnc I forgot to run it when I added the first strncmp() patchset, but it worked on the patchset before and after that one. -- To view, visit http://gerrit.cloudera.org:8080/10265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2 Gerrit-Change-Number: 10265 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 03 May 2018 17:41:28 +0000 Gerrit-HasComments: Yes
