Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java: http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@134 PS2, Line 134: expectedPrivileges nit: per conversation, can we rename to expectedAuthorizables? or expectedPrivilegeRequestNames? http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@549 PS2, Line 549: authorize("use functional") There should be .ok() tests for onDatabase, onTable, and onColumn. -- To view, visit http://gerrit.cloudera.org:8080/10269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b Gerrit-Change-Number: 10269 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Thu, 03 May 2018 21:30:59 +0000 Gerrit-HasComments: Yes
