Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10301 )
Change subject: IMPALA-6968: Fix TestBlockVerification flakiness ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Great find! Thanks for fixing it so quickly. http://gerrit.cloudera.org:8080/#/c/10301/2/be/src/runtime/tmp-file-mgr-test.cc File be/src/runtime/tmp-file-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/10301/2/be/src/runtime/tmp-file-mgr-test.cc@545 PS2, Line 545: data[0] > Yeah that's correct, we encrypt in-place in-memory then start the write to Thanks for the clarification. -- To view, visit http://gerrit.cloudera.org:8080/10301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf063ff32848035af667c7cd2a1268f5b785cfe Gerrit-Change-Number: 10301 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 03 May 2018 23:23:45 +0000 Gerrit-HasComments: Yes