Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21207 )
Change subject: IMPALA-12426: Skip Inserting HS2 Operation Queries into the Completed Queries Table ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/21207/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21207/8//COMMIT_MSG@9 PS8, Line 9: HS2 operations nit: HS2 metadata operations http://gerrit.cloudera.org:8080/#/c/21207/8/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21207/8/be/src/service/workload-management.cc@21 PS8, Line 21: #include <forward_list> nit: unused? http://gerrit.cloudera.org:8080/#/c/21207/8/be/src/service/workload-management.cc@30 PS8, Line 30: #include <boost/algorithm/string.hpp> nit: unused? http://gerrit.cloudera.org:8080/#/c/21207/8/be/src/service/workload-management.cc@56 PS8, Line 56: using namespace boost::algorithm; nit: unused? -- To view, visit http://gerrit.cloudera.org:8080/21207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie19cf5953522fa85941e6c0b9c15a9c9ba9dc362 Gerrit-Change-Number: 21207 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Mar 2024 20:15:25 +0000 Gerrit-HasComments: Yes
