Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21221 )
Change subject: IMPALA-12944: Fixes Workload Management Test Flakiness ...................................................................... Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21221/6/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21221/6/tests/common/impala_test_suite.py@1270 PS6, Line 1270: return \ : self.assert_log_contains( nit: looks better if breaking after parenthesis. No need for backslash. http://gerrit.cloudera.org:8080/#/c/21221/6/tests/common/impala_test_suite.py@1293 PS6, Line 1293: Returns the result of the very last call to line_regex.search. nit: "Returns the result of the very last call to line_regex.search or None if expected_count=0." http://gerrit.cloudera.org:8080/#/c/21221/3/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21221/3/tests/custom_cluster/test_query_log.py@73 PS3, Line 73: > Will it? It looks specifically at impalad.INFO, which should be new for eve Right, nevermind. I look again and test_breakpad.py has its own assert_logs() method. I did stumble upon that back then. assert_impalad_log_contains() looks safe since it resolve symlink and target just 1 file. -- To view, visit http://gerrit.cloudera.org:8080/21221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I428702a210e024db95808dc2518da497426922f8 Gerrit-Change-Number: 21221 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Mar 2024 22:53:53 +0000 Gerrit-HasComments: Yes
