Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18868 )
Change subject: IMPALA-5323: Support BINARY columns in Kudu tables ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18868/5/testdata/workloads/functional-query/queries/QueryTest/binary-type.test File testdata/workloads/functional-query/queries/QueryTest/binary-type.test: http://gerrit.cloudera.org:8080/#/c/18868/5/testdata/workloads/functional-query/queries/QueryTest/binary-type.test@170 PS5, Line 170: ants folding and non ascii char > oops, what I wrote is incorrect Cleaned up the commit message. It was confusing binary and string - case a. was only possible for STRING as a BINARY constant will always have a cast and need constant folding. -- To view, visit http://gerrit.cloudera.org:8080/18868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff701a4b3a09ce7b6982c5d238e65f3d4f3d1151 Gerrit-Change-Number: 18868 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 03 Apr 2024 18:48:41 +0000 Gerrit-HasComments: Yes
