Hello Zihao Ye, Michael Smith, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21129 to look at the new patch set (#2). Change subject: IMPALA-10057: Fix log spew by using jars in the classpath ...................................................................... IMPALA-10057: Fix log spew by using jars in the classpath Some tests saw log spew that causes the INFO log files to be filled with output like this: E0903 02:25:39.453887 12060 TransactionKeepalive.java:137] Unexpected exception thrown Java exception follows: java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError: org/apache/impala/common/TransactionKeepalive$HeartbeatContext at org.apache.impala.common.TransactionKeepalive$DaemonThread.run(TransactionKeepalive.java:114) at java.lang.Thread.run(Thread.java:748) ... It turns out that the catalogd/impalad use a CLASSPATH in tests that refers to fe/target/classes. The maven command that runs frontend tests recompiles these classes and causes the files in fe/target/classes to be deleted and recreated. There are race conditions where this causes the symptoms above. This changes the CLASSPATH to use the frontend jars, which are not impacted by the machinations on fe/target/classes. To find the appropriate jar, set-classpath.sh needs to know the Impala version. This adds IMPALA_VERSION in bin/impala-config.sh to provide an easy to use environment variable. To make the versioning more uniform, this modifies bin/save-version.sh to use this environment variable. It also adds a check to make sure that the Java pom.xml files use the same version as the environment variable. It fails the build if the Java pom.xml files do not match. Testing: - Ran core jobs - Checked the log file sizes on jobs - Changed a Java pom.xml's version and verified that bin/validate-java-pom-versions.sh fails Merge conflicts: - Change version string "4.1.0" to "3.4.2". Change-Id: Id35544e446c5bf283c322d3fe2e7ad475cfa12eb Reviewed-on: http://gerrit.cloudera.org:8080/18415 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Michael Smith <michael.sm...@cloudera.com> Reviewed-by: Quanlong Huang <huangquanl...@gmail.com> Reviewed-on: http://gerrit.cloudera.org:8080/18879 Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com> Tested-by: Quanlong Huang <huangquanl...@gmail.com> --- M bin/impala-config.sh M bin/save-version.sh M bin/set-classpath.sh A bin/validate-java-pom-versions.sh M common/yarn-extras/pom.xml M ext-data-source/api/pom.xml M ext-data-source/pom.xml M ext-data-source/sample/pom.xml M ext-data-source/test/pom.xml M fe/pom.xml M impala-parent/CMakeLists.txt M impala-parent/pom.xml M query-event-hook-api/pom.xml M shaded-deps/pom.xml M testdata/TableFlattener/pom.xml M testdata/pom.xml M tests/test-hive-udfs/pom.xml 17 files changed, 113 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/21129/2 -- To view, visit http://gerrit.cloudera.org:8080/21129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-3.4.2 Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id35544e446c5bf283c322d3fe2e7ad475cfa12eb Gerrit-Change-Number: 21129 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com>