Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 )
Change subject: IMPALA-12905: Disk-based tuple caching ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.h File be/src/exec/tuple-cache-node.h: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.h@27 PS6, Line 27: class TupleFileReader; > Setting default destructor in tuple-cache-node.cc sounds like a good safety Done http://gerrit.cloudera.org:8080/#/c/21171/8/be/src/exec/tuple-file-read-write-test.cc File be/src/exec/tuple-file-read-write-test.cc: http://gerrit.cloudera.org:8080/#/c/21171/8/be/src/exec/tuple-file-read-write-test.cc@182 PS8, Line 182: // Read back the empy file and make sure the reader can handle it > typo: empy -> empty Done http://gerrit.cloudera.org:8080/#/c/21171/8/be/src/exec/tuple-file-reader.cc File be/src/exec/tuple-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/21171/8/be/src/exec/tuple-file-reader.cc@99 PS8, Line 99: // Now, we know the total size of the variable-length data, and we can read > ReadV already supports populating multiple kudu::Slice, should we do this a Done http://gerrit.cloudera.org:8080/#/c/21171/8/be/src/exec/tuple-file-writer.h File be/src/exec/tuple-file-writer.h: http://gerrit.cloudera.org:8080/#/c/21171/8/be/src/exec/tuple-file-writer.h@109 PS8, Line 109: bool aborted_ = false; > Could these be a state enum instead? Reworked it to be an enum http://gerrit.cloudera.org:8080/#/c/21171/8/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/21171/8/tests/custom_cluster/test_tuple_cache.py@101 PS8, Line 101: start_args=CACHE_START_ARGS + " --tuple_cache_capacity=64MB", cluster_size=1, > This arg doesn't exist anymore, right? bin/start-impala-cluster.py still has them split out, because that is more convenient. So this is specifying start-impala-cluster.py's argument rather than the impalad startup flag. -- To view, visit http://gerrit.cloudera.org:8080/21171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a65c4c0559cad3559d5f714a074dd06e9cc9bf Gerrit-Change-Number: 21171 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 18:48:17 +0000 Gerrit-HasComments: Yes