Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10302 )
Change subject: Move admission-controller and catalog metrics into own groups ...................................................................... Patch Set 2: I'm not aware of any tools that depend on the group structure. The current organisation is a total mess - there's no alignment between the metric groups and the metric names - so I think any sane tool would just be walking the structure and picking out metrics by the full name rather than depending on the structure (or using the /jsonmetrics endpoint) Ideally we'd rework this so that the metric names and groups were automatically consistent but I'm just scratching my own itch here. -- To view, visit http://gerrit.cloudera.org:8080/10302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17dbbcebc01cc1f5b8e94e593873cdc3dc5e36df Gerrit-Change-Number: 10302 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 07 May 2018 16:29:24 +0000 Gerrit-HasComments: No
