Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21304 )
Change subject: WIP IMPALA-12910: Support running TPCH/TPCDS queries for JDBC tables ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/21304/1/testdata/bin/create-tpc-jdbc-tables.py File testdata/bin/create-tpc-jdbc-tables.py: http://gerrit.cloudera.org:8080/#/c/21304/1/testdata/bin/create-tpc-jdbc-tables.py@41 PS1, Line 41: def drop_tables(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21304/1/testdata/bin/create-tpc-jdbc-tables.py@47 PS1, Line 47: def create_tables(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21304/1/testdata/bin/create-tpc-jdbc-tables.py@58 PS1, Line 58: flake8: E202 whitespace before '}' http://gerrit.cloudera.org:8080/#/c/21304/1/testdata/bin/create-tpc-jdbc-tables.py@74 PS1, Line 74: def get_test_file_path(workload): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21304/1/testdata/bin/create-tpc-jdbc-tables.py@83 PS1, Line 83: if __name__ == "__main__": flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/21304/1/tests/query_test/test_tpcds_queries.py File tests/query_test/test_tpcds_queries.py: http://gerrit.cloudera.org:8080/#/c/21304/1/tests/query_test/test_tpcds_queries.py@1119 PS1, Line 1119: d flake8: E301 expected 1 blank line, found 0 -- To view, visit http://gerrit.cloudera.org:8080/21304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44e8c1bb020e90559c7f22483a7ab7a151b8f48a Gerrit-Change-Number: 21304 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Apr 2024 01:14:23 +0000 Gerrit-HasComments: Yes