Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21294 )
Change subject: IMPALA-12874: Identify active and standby catalog and statestore the web debug endpoint ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21294/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21294/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12874: Identify active and standby catalog and statestore the web debug endpoint Incomplete sentence: "Identify active and standby catalog and statestore daemon in the web debug endpoint" http://gerrit.cloudera.org:8080/#/c/21294/2//COMMIT_MSG@20 PS2, Line 20: Manually tests the web page, and verified the status display is : correct. If there is a failover does the status get updated? Can we also test that? http://gerrit.cloudera.org:8080/#/c/21294/2/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/21294/2/be/src/util/default-path-handlers.cc@271 PS2, Line 271: } else { admissiond also uses DaemonEnv, we should handle that case also. Maybe exit early in case of admissiond? -- To view, visit http://gerrit.cloudera.org:8080/21294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9435ba7a9549ea56f9d080a9315aecbcc630cd2 Gerrit-Change-Number: 21294 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 16 Apr 2024 02:37:37 +0000 Gerrit-HasComments: Yes
