Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21284 )
Change subject: IMPALA-12990: Fix impala-shell handling of unset rows_deleted ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/21284/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21284/6/shell/impala_client.py@315 PS6, Line 315: in that order. If the DML operation doesn't return 'rows_deleted' or > Comment should probably also address unset num_deleted_rows -> None as well Done http://gerrit.cloudera.org:8080/#/c/21284/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21284/6/shell/impala_shell.py@1366 PS6, Line 1366: return "Time elapsed: %2.2fs" % time_elapsed > Are there tests covering this? Manual testing suggests it should work in Py There is a test using strict hs2 protocol: https://github.com/apache/impala/blob/61ceb16d880a7be07241f682138bfb286ec2a80e/tests/shell/test_shell_commandline.py#L914 -- To view, visit http://gerrit.cloudera.org:8080/21284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5812b8006b9cacf34a7a0dbbc89a486d8b454438 Gerrit-Change-Number: 21284 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Apr 2024 06:03:32 +0000 Gerrit-HasComments: Yes
