Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21277 )
Change subject: IMPALA-12988: Calculate an unbounded version of CpuAsk ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/21277/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21277/11//COMMIT_MSG@35 PS11, Line 35: field > plural - 'fields'? This is referring to fragment level parallelism, right? Yes, fragment level parallelism. Will change to 'fields'. http://gerrit.cloudera.org:8080/#/c/21277/11//COMMIT_MSG@36 PS11, Line 36: The CpuAsk : counter is changed to show the unbounded CpuAsk after scaling. A new : counter CpuAskBounded shows the bounded CpuAsk after scaling. The : EffectiveParallelism counter remains unchanged, showing bounded CpuAsk : before scaling. > This is a little confusing. Should pick the unbounded CpuAsk after scaling. Will fix the code and commit message. http://gerrit.cloudera.org:8080/#/c/21277/11/fe/src/main/java/org/apache/impala/planner/CostingSegment.java File fe/src/main/java/org/apache/impala/planner/CostingSegment.java: http://gerrit.cloudera.org:8080/#/c/21277/11/fe/src/main/java/org/apache/impala/planner/CostingSegment.java@85 PS11, Line 85: topNode = fragment.getPlanRoot(); > topNode not really being used? I can leave it unassigned for this branch. -- To view, visit http://gerrit.cloudera.org:8080/21277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5441e31088f90761062af35862be4ce09d116923 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Apr 2024 20:25:46 +0000 Gerrit-HasComments: Yes
