Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21331 )
Change subject: IMPALA-12950:Improve error message in case of out-of-range numeric conversions ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/21331/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21331/2//COMMIT_MSG@7 PS2, Line 7: : nit: missing whitespace http://gerrit.cloudera.org:8080/#/c/21331/2//COMMIT_MSG@12 PS2, Line 12: floating point nit: floating-point http://gerrit.cloudera.org:8080/#/c/21331/2/be/src/exprs/cast-functions-ir.cc File be/src/exprs/cast-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21331/2/be/src/exprs/cast-functions-ir.cc@76 PS2, Line 76: } The default case is missing, it could be added as "UNKNOWN TYPE" or something similar. http://gerrit.cloudera.org:8080/#/c/21331/2/be/src/exprs/cast-functions-ir.cc@182 PS2, Line 182: err = Substitute("NaN value of type $0 cannot be converted to $1.", Could you please add test cases to cover each condition? -- To view, visit http://gerrit.cloudera.org:8080/21331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeed52e25f155818c35c11a8a6821708476ffb32 Gerrit-Change-Number: 21331 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Apr 2024 12:25:05 +0000 Gerrit-HasComments: Yes
