Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21304 )
Change subject: IMPALA-12910: Support running TPCH/TPCDS queries for JDBC tables ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/21304/6/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/21304/6/be/src/service/frontend.cc@99 PS6, Line 99: DEFINE_int32(dbcp_max_conn_pool_size, 8, > Ah, that makes it trickier. I assumed the point of this setting is to limit This parameter limit each connection pool size, e.g. number of concurrent TCP connections in a pool. We create DBCP connection pool for each unique combination of database and username, which is implemented by setting cache key as dataSourceCacheKey = String.format("%s.%s", jdbcUrl, username) in GenericJdbcDatabaseAccessor.initializeDatabaseSource(). Each DataSource object corresponds to one connection pool. http://gerrit.cloudera.org:8080/#/c/21304/12/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java: http://gerrit.cloudera.org:8080/#/c/21304/12/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@93 PS12, Line 93: synchronized (this) { > Ah, synchronized methods would have only prevented other calls to the same 'get', 'remove' and 'cleanup' use same synchronized object 'this'. Multiple threads will not able to run multiple methods on the same synchronized object simultaneously. http://gerrit.cloudera.org:8080/#/c/21304/12/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@148 PS12, Line 148: } catch (InterruptedException e) { > I think the only exception we'd see here is InterruptedException, which doe Lower the log level to info -- To view, visit http://gerrit.cloudera.org:8080/21304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44e8c1bb020e90559c7f22483a7ab7a151b8f48a Gerrit-Change-Number: 21304 Gerrit-PatchSet: 14 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Apr 2024 23:26:28 +0000 Gerrit-HasComments: Yes
