Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 )
Change subject: IMPALA-13005: Create Query Live table in HMS ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21302/8/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21302/8/be/src/service/workload-management.cc@326 PS8, Line 326: log_table_ > Nit: now that we are dealing with 2 tables, rename variable to query_log or Done http://gerrit.cloudera.org:8080/#/c/21302/8/be/src/service/workload-management.cc@333 PS8, Line 333: ABORT_IF_ERROR(SetupDb(internal_server_.get())); > This TODO isn't needed. Done -- To view, visit http://gerrit.cloudera.org:8080/21302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf302ee54a819fdee2db0ae582a5eeddffe4a5b4 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 23:42:58 +0000 Gerrit-HasComments: Yes
