Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21345 )
Change subject: IMPALA-12997: Use graceful shutdown for query log tests ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21345/4/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21345/4/tests/common/custom_cluster_test_suite.py@120 PS4, Line 120: None) > Perhaps this should change to None, and the check in L153 change to "is not Done http://gerrit.cloudera.org:8080/#/c/21345/4/tests/common/custom_cluster_test_suite.py@222 PS4, Line 222: method > method is used before checking if it's not None in next line Later lines expect method to not be None, so I suspect this was overly defensive coding. Going to remove the 'method is not None' check. http://gerrit.cloudera.org:8080/#/c/21345/4/tests/common/custom_cluster_test_suite.py@226 PS4, Line 226: assert impalad.get_pid() is None > Can you put assert message? Maybe like: Done http://gerrit.cloudera.org:8080/#/c/21345/4/tests/common/custom_cluster_test_suite.py@227 PS4, Line 227: "imp > Can change to else: Done -- To view, visit http://gerrit.cloudera.org:8080/21345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia123c53a952a77ff4a9c02736b5717ccaa3566dc Gerrit-Change-Number: 21345 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 16:48:40 +0000 Gerrit-HasComments: Yes
