Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21351 )
Change subject: IMPALA-13012: Lower default query_log_max_queued ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21351/2/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21351/2/be/src/service/workload-management.cc@441 PS2, Line 441: "gather_time=" << PrettyPrinter::Print(gather_time, TUnit::TIME_NS) << " " : "exec_time=" << PrettyPrinter::Print(exec_time, TUnit::TIME_NS); > Yeah, a histogram for these would be useful. I'll add it. Hmm, what combination. Could go minimal with one histogram for all gather+exec time (with logs to look at the details), or maximal tracking gather and exec separately across succeeded or failed queries. My instinct is minimal to make it easier to monitor, and rely on logs for more detail. -- To view, visit http://gerrit.cloudera.org:8080/21351 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6535675307d88cb65ba7d908f3c692e0cf3259d7 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 18:53:46 +0000 Gerrit-HasComments: Yes
