Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21358 )
Change subject: Refactor Workload Management ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21358/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21358/1//COMMIT_MSG@6 PS1, Line 6: : Refactor Workload Management > Please assign JIRA number. Will do, this refactor isn't urgent but I wanted to toss up some ideas. http://gerrit.cloudera.org:8080/#/c/21358/1/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21358/1/tests/custom_cluster/test_query_log.py@255 PS1, Line 255: "--shutdown_grace_period_s=10 " TODO: when 'impalad_graceful_shutdown=True', add reasonable default 'shutdown_grace_period_s' and 'shutdown_deadline_s'. 'shutdown_grace_period_s=0' is probably fine, as test queries are fast and ShutdownWorkloadManagement doesn't run until after the grace period. -- To view, visit http://gerrit.cloudera.org:8080/21358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1127ef041a3e024bf2b262767d56ec5f29bf3855 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 22:07:28 +0000 Gerrit-HasComments: Yes
