Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21160 )
Change subject: IMPALA-12921: Support locally built Ranger ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/21160/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21160/7//COMMIT_MSG@64 PS7, Line 64: - Verified that this patch passed the core tests. Do you mean using Apache Ranger? That would be great! http://gerrit.cloudera.org:8080/#/c/21160/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/21160/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@500 PS7, Line 500: SELECT_ACCESS_TYPE, user.getShortName(), getUserGroups(user), null); It seems using the empty constructor and setting the fields later is a more compatible way. As shown in Yubi's patch here: https://gerrit.cloudera.org/c/18977/17/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java -- To view, visit http://gerrit.cloudera.org:8080/21160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I268d6d4d6e371da7497aac8d12f78178d57c6f27 Gerrit-Change-Number: 21160 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sun, 28 Apr 2024 08:58:06 +0000 Gerrit-HasComments: Yes
