Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21361 )
Change subject: IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21361/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21361/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3672 PS3, Line 3672: Preconditions.checkArgument(IcebergMetadataTable.canBeIcebergMetadataTable(tblRefPath)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21361/3/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergMetadataTable.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergMetadataTable.java: http://gerrit.cloudera.org:8080/#/c/21361/3/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergMetadataTable.java@150 PS3, Line 150: return catalogTable instanceof FeIcebergTable || catalogTable instanceof IcebergMetadataTable; line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7c25ed85a8813011537c73f0aaf72db1501f9ef Gerrit-Change-Number: 21361 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Apr 2024 11:24:36 +0000 Gerrit-HasComments: Yes
