pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 13: (6 comments) > Uploaded patch set 13. http://gerrit.cloudera.org:8080/#/c/21131/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21131/12//COMMIT_MSG@15 PS12, Line 15: " > Use double quotes here ("\u00FF"), this is not a valid character literal bu Done http://gerrit.cloudera.org:8080/#/c/21131/12//COMMIT_MSG@18 PS12, Line 18: wo key changes: > "the special characters that need to be escaped" would be better, it's not Done http://gerrit.cloudera.org:8080/#/c/21131/12//COMMIT_MSG@18 PS12, Line 18: > I think it could be formulated better. There are two things that have chang Done http://gerrit.cloudera.org:8080/#/c/21131/12//COMMIT_MSG@18 PS12, Line 18: > Nit: no need for the comma here. Done http://gerrit.cloudera.org:8080/#/c/21131/12/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/12/be/src/util/coding-util.cc@19 PS12, Line 19: > Let's fix include groups: there should be an empty line after #include "uti Done http://gerrit.cloudera.org:8080/#/c/21131/12/be/src/util/coding-util.cc@50 PS12, Line 50: '\f', > This could be '\f' (form feed), see https://www.compart.com/en/unicode/U+00 Done -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Tue, 30 Apr 2024 11:13:58 +0000 Gerrit-HasComments: Yes
