Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 )
Change subject: IMPALA-13020: Change thrift_rpc_max_message_size to int64_t ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21367/4/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/21367/4/be/src/rpc/thrift-util.cc@61 PS4, Line 61: DEFINE_int64(thrift_rpc_max_message_size, 4L * 1024 * 1024 * 1024, Yeah, it'd be perfect if we can split up them. We already have a pretty large limit. A query sent from the client shouldn't need that large. > Is 8GB reasonable? It's hard to estimate the ratio since it depends on many factors, e.g. number of partitions. However, it's reported in IMPALA-12350 that 800MB could grow to 3.4GB after upgrade. So 4x larger is possible in reality and 4GB x 4 = 16GB might be safer. -- To view, visit http://gerrit.cloudera.org:8080/21367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I681b1849cc565dcb25de8c070c18776ce69cbb87 Gerrit-Change-Number: 21367 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 07 May 2024 04:02:59 +0000 Gerrit-HasComments: Yes
