Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 )
Change subject: IMPALA-13018: Fix test_tpcds_q80a for JDBC table ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21409/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21409/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-13018: Fix test_tpcds_q80a for JDBC table Maybe update the title to something generic, since this applies to other queries also and not just this particular query. Maybe: "Block push down of conjuncts with expressions on base column values for jdbc tables" http://gerrit.cloudera.org:8080/#/c/21409/1//COMMIT_MSG@17 PS1, Line 17: But casting to Date/Timestamp for a column cannot be pushed down to JDBC I'm wondering if this applies to other non Date/Timestamp types also? Can we do proper pushdown if TBinaryPredicate expects TColumnDesc to be one of the operands. struct TBinaryPredicate { // Column on which the predicate is applied. Always set. 1: optional TColumnDesc col // Comparison operator. Always set. 2: optional TComparisonOp op // Value on the right side of the binary predicate. Always set. 3: optional Data.TColumnValue value } Basically, if you have predicate like following, can it be properly pushed down? CAST (stringCol AS INT) >= 1234 -- To view, visit http://gerrit.cloudera.org:8080/21409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd7e28b8d5f11f25a000dc4c9ab65895056b572 Gerrit-Change-Number: 21409 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 07 May 2024 19:35:23 +0000 Gerrit-HasComments: Yes
