Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 )
Change subject: IMPALA-13038: Support profile tab for imported query profiles ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21400/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/21400/3/be/src/service/impala-http-handler.cc@307 PS3, Line 307: if (!parse_status.ok()) { > Move these after parse_status error check. Done http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl File www/query_profile.tmpl: http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl@62 PS3, Line 62: result = `${result}${indent} Offset: ${eventSeq.offset}\n`; > Check performance of these repeated appends. It may be better to accumulate Done. I have further optimized these by reducing number of concatenations. Currently, JSON profiles upto 250MBs do not pose a problem as they can be stored in indexedDB. Much larger profiles have to be stored after compression. This can be implemented through Compression Stream APIs available in recent browsers(2023 and afterwards). I am planning to implement this in the next patch. http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl@113 PS3, Line 113: }; > Is there a tag that can be checked here? Please add a comment of where this Done -- To view, visit http://gerrit.cloudera.org:8080/21400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddcf2e285abbf42f97bde19014be076ccd6374bc Gerrit-Change-Number: 21400 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 08 May 2024 16:38:55 +0000 Gerrit-HasComments: Yes
