Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 )
Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21394/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21394/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-13055: Some Iceberg metadata table tests don't assert > Do you think it is an error in the test framework? If so, could you open a created a ticket, added it to the commit msg. http://gerrit.cloudera.org:8080/#/c/21394/1//COMMIT_MSG@11 PS1, Line 11: unconditionally passes > We should make it clear the it is not the actual result from Impala that ca Well, that's kind of the same, right? If the expected result can be anything, then the actual result can be anything and the test will still pass. http://gerrit.cloudera.org:8080/#/c/21394/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/21394/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@49 PS1, Line 49: > Is adding VERIFY_IS_SUBSET needed? I ran the test locally without it and it I re-run this without VERIFY_IS_SUSBET a few times and apparently it passes. So probably this is not needed. http://gerrit.cloudera.org:8080/#/c/21394/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@365 PS1, Line 365: #### > This comment is stale, we should change it. Actually we have a separate section for complex types and this one should have been removed by one of the "complex types in metadata tables" patch. Removing it now. http://gerrit.cloudera.org:8080/#/c/21394/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@371 PS1, Line 371: }-\d{2 > As this test section deals with complex types, I think we shouldn't put a w see above -- To view, visit http://gerrit.cloudera.org:8080/21394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie47093f25a70253b3e6faca27d466d7cf6999fad Gerrit-Change-Number: 21394 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 09 May 2024 10:55:10 +0000 Gerrit-HasComments: Yes
