Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21429 )
Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21429/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc File be/src/exec/iceberg-metadata/iceberg-row-reader.cc: http://gerrit.cloudera.org:8080/#/c/21429/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@125 PS1, Line 125: are NULLed out. represented as NULL, or displayed as NULL. NULLed out sounds a bit unusual. http://gerrit.cloudera.org:8080/#/c/21429/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@125 PS1, Line 125: string warning = "DECIMAL values from Iceberg metadata tables are NULLed out."; The warning string could be extracted as a constant. http://gerrit.cloudera.org:8080/#/c/21429/1/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@126 PS1, Line 126: LOG(WARNING) << warning; With this approach, the warning will be posted as many times the query encounters a decimal, it would be better to post the warning once. -- To view, visit http://gerrit.cloudera.org:8080/21429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c8791805bc4fa2112e092e65366ca2815f3fa22 Gerrit-Change-Number: 21429 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Thu, 16 May 2024 09:03:34 +0000 Gerrit-HasComments: Yes
