Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 )
Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21444/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java File fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java: http://gerrit.cloudera.org:8080/#/c/21444/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java@178 PS1, Line 178: private void verify() { What if we move the check inside the verify() method? if (!BackendConfig.INSTANCE.isReleaseBuild()) return; -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 20 May 2024 21:53:03 +0000 Gerrit-HasComments: Yes
