Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 )
Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/client-request-state.h@506 PS3, Line 506: void UpdateClientFetchLockWaitTime(int64_t lock_wait_time_ns) { another review uses "AddFetchLockWaitTime" for similar purpose. https://gerrit.cloudera.org/#/c/20850/16/be/src/service/client-request-state.h "add" seems clearer to me in this case than "update" http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-beeswax-server.cc@352 PS3, Line 352: VLOG(1) << "Error in get_log: " << status.GetDetail(); Is this supposed to be a long term log? It could contain more information, e.g. "Error in get_log, could not get query handle:" http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-hs2-server.cc@1099 PS3, Line 1099: VLOG(1) << "Error in GetLog: " << status.GetDetail(); Same as in impala-beeswax-server.cc -- To view, visit http://gerrit.cloudera.org:8080/21412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I538ebe914f70f460bc8412770a8f7a1cc8b505dc Gerrit-Change-Number: 21412 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 21 May 2024 11:03:26 +0000 Gerrit-HasComments: Yes
